Skip to content

Conversation

@gadomski
Copy link
Member

@gadomski gadomski commented Feb 3, 2025

Description:

dev-depdendencies are considered legacy now. Also does some cleanup of CI. No CHANGELOG needed.

PR Checklist:

  • Pre-commit hooks and tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.

@gadomski gadomski requested a review from jsignell February 3, 2025 13:51
@gadomski gadomski self-assigned this Feb 3, 2025
Comment on lines -90 to -111
lint:
runs-on: ubuntu-latest
strategy:
matrix:
python-version:
- "3.10"
- "3.11"
- "3.12"
- "3.13"
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- uses: astral-sh/setup-uv@v5
with:
enable-cache: true
- name: Sync
run: uv sync
- name: Execute linters & type checkers
run: uv run pre-commit run --all-files

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel like we need a separate lint job, moved this to the main check.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives us a default Python version for uv in CI, but doesn't force it for downstream users or anything.

@codecov
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.47%. Comparing base (f991340) to head (7ab9566).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1517   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files          54       54           
  Lines        7542     7542           
  Branches      915      915           
=======================================
  Hits         6899     6899           
  Misses        457      457           
  Partials      186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that is much cleaner. This is making me wonder how you feel about the top-level scripts to rule them all. I don't tend to use them with library development.

@gadomski
Copy link
Member Author

gadomski commented Feb 3, 2025

This is making me wonder how you feel about the top-level scripts to rule them all. I don't tend to use them with library development.

Same. #1518

@gadomski gadomski added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit 69e2cb0 Feb 3, 2025
19 checks passed
@gadomski gadomski deleted the use-dependency-groups branch February 3, 2025 16:09
kmodali pushed a commit to kmodali/pystac that referenced this pull request Oct 16, 2025
* chore: use dependency-groups

* feat: add python version

* fix: don't run lints on windoze
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants