-
Couldn't load subscription status.
- Fork 126
Add Collection.from_items
#1522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1522 +/- ##
==========================================
+ Coverage 91.47% 91.50% +0.03%
==========================================
Files 54 54
Lines 7542 7571 +29
Branches 915 922 +7
==========================================
+ Hits 6899 6928 +29
Misses 457 457
Partials 186 186 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just one doc touchup
* Add Collection.from_items * Fix datetime for python 3.10 * More tests, fix docs * Use `Collection` rather than TypeVar * Update changelog * objections -> objects
Related Issue(s):
ItemCollection.to_collection#1254Description:
I ended up implementing this the opposite direction from the original proposal as mentioned in the ticket. There are probably more attributes that we can scrape off the items especially once #1521 shakes out.
PR Checklist:
pre-commit run --all-files)pytest)