Skip to content

FIX: update tests for github runner drive changes #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

FIX: update tests for github runner drive changes #1563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5fe003
change drive to C:/
tylanderson Jun 18, 2025
47ab5d9
update changelog
tylanderson Jun 18, 2025
36a3da5
move to windows-2025
tylanderson Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- "3.13"
os:
- ubuntu-latest
- windows-latest
- windows-2025
- macos-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -45,7 +45,7 @@ jobs:
if: runner.os == 'Windows'
shell: bash
env:
TMPDIR: 'D:\\a\\_temp'
TMPDIR: 'C:\\a\\_temp'
run: uv run pytest tests
- name: Test
if: runner.os != 'Windows'
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
media type value for these types and new media types COPC and VND_PMTILES
([#1554](https://github.com/stac-utils/pystac/pull/1554))

### Changed

- Update drive used by windows runners during tests

### Fixed

- More permissive collection extent deserialization ([#1559](https://github.com/stac-utils/pystac/pull/1559))
Expand Down
6 changes: 3 additions & 3 deletions tests/test_layout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ class TestAsIsLayoutStrategy:
def test_catalog(self) -> None:
strategy = AsIsLayoutStrategy()
expected_local_href = (
"/an/href" if not path_includes_drive_letter() else "D:/an/href"
"/an/href" if not path_includes_drive_letter() else "C:/an/href"
)
cat = pystac.Catalog(id="test", description="test desc")
with pytest.raises(ValueError):
Expand All @@ -417,7 +417,7 @@ def test_catalog(self) -> None:
def test_collection(self) -> None:
strategy = AsIsLayoutStrategy()
expected_local_href = (
"/an/href" if not path_includes_drive_letter() else "D:/an/href"
"/an/href" if not path_includes_drive_letter() else "C:/an/href"
)
collection = TestCases.case_8()
collection.set_self_href(None)
Expand All @@ -432,7 +432,7 @@ def test_collection(self) -> None:
def test_item(self) -> None:
strategy = AsIsLayoutStrategy()
expected_local_href = (
"/an/href" if not path_includes_drive_letter() else "D:/an/href"
"/an/href" if not path_includes_drive_letter() else "C:/an/href"
)
collection = TestCases.case_8()
item = next(collection.get_items(recursive=True))
Expand Down
Loading