Skip to content

Conversation

@jonas-hurst
Copy link
Contributor

@jonas-hurst jonas-hurst commented Aug 13, 2025

Description:

Continuation from #1556

Finally found the time to cherry-pick my added commits to a new branch to make reviewing and merging easier

PR Checklist:

  • Pre-commit hooks pass (run pre-commit run --all-files)
  • Tests pass (run pytest)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@jonas-hurst jonas-hurst mentioned this pull request Aug 13, 2025
5 tasks
@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 98.53480% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.46%. Comparing base (065a631) to head (88c3058).

Files with missing lines Patch % Lines
pystac/extensions/mlm.py 98.52% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1571      +/-   ##
==========================================
+ Coverage   92.32%   92.46%   +0.13%     
==========================================
  Files          55       55              
  Lines        8381     8582     +201     
  Branches      966     1038      +72     
==========================================
+ Hits         7738     7935     +197     
- Misses        457      458       +1     
- Partials      186      189       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonas-hurst
Copy link
Contributor Author

pinging @romeokienzler for a code review

@romeokienzler
Copy link

@jonas-hurst I'm in for the review - let me take a look!

@gadomski gadomski self-requested a review August 14, 2025 16:24
Copy link

@romeokienzler romeokienzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants