Skip to content

Conversation

@jsignell
Copy link
Member

@jsignell jsignell requested a review from gadomski September 22, 2025 14:01
@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.38%. Comparing base (a5e0408) to head (6f9503f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1582   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files          55       55           
  Lines        8375     8375           
  Branches      965      965           
=======================================
  Hits         7737     7737           
  Misses        453      453           
  Partials      185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gadomski
gadomski previously approved these changes Sep 22, 2025
@gadomski gadomski self-requested a review September 22, 2025 15:05
@gadomski gadomski dismissed their stale review September 22, 2025 15:06

Looks like CI is failing on RTD

@jsignell
Copy link
Member Author

Yeah sorry requested review too soon. Still messing with this one 🤦🏻

@jsignell jsignell marked this pull request as draft September 22, 2025 15:24
@jsignell
Copy link
Member Author

Ok so maybe the issue with the docs build on this repo is different. It looks like the docs are building successfully on release and main. They just aren't getting the right version numbers applied. I am doing an experiment where I try to trigger a manual build of v1.14.1 and v1.13.0 via the readthedocs dashboard.

@jsignell
Copy link
Member Author

The last version that had been successfully built with its version info was version 1.0 which is not prefixed with a v and has only 2 positions. Those readthedocs were built off a branch apparently. Not sure if any of that matters or not.

Anyways versions before 1.11.0 don't build because of changed requirements about what is included in .readthedocs.yml

@jsignell jsignell closed this Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants