Skip to content

add object-store-aws test#619

Merged
gadomski merged 5 commits intostac-utils:mainfrom
jrjdavidson:aws-test
Feb 3, 2025
Merged

add object-store-aws test#619
gadomski merged 5 commits intostac-utils:mainfrom
jrjdavidson:aws-test

Conversation

@jrjdavidson
Copy link
Contributor

@jrjdavidson jrjdavidson commented Feb 2, 2025

small change to add object-store-aws test, also add example on how to use keys.

@jrjdavidson jrjdavidson requested a review from gadomski as a code owner February 2, 2025 20:28
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind having a network-touching test, but I'd prefer it as a "regular" test (not a doctest) or an "integration" test (in a tests diretory) which will make it easier to skip/ignore later on if (e.g.) the network location breaks.

Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
@jrjdavidson
Copy link
Contributor Author

I don't mind having a network-touching test, but I'd prefer it as a "regular" test (not a doctest) or an "integration" test (in a tests diretory) which will make it easier to skip/ignore later on if (e.g.) the network location breaks.

Good point about network location potentially breaking.

It took me a little while to figure out how to pass the options to object_store ( i had to explore the object_store crate and try various keys) and thought having an actual working example in the docs might help someone in the future.

@gadomski

This comment was marked as outdated.

Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@gadomski gadomski enabled auto-merge (squash) February 3, 2025 19:32
@gadomski gadomski merged commit eb404cf into stac-utils:main Feb 3, 2025
10 checks passed
@jrjdavidson jrjdavidson deleted the aws-test branch May 30, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants