Skip to content

fix errors when search returns no body #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix errors when search returns no body #594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 20 additions & 17 deletions src/stac_api_validator/validations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3199,23 +3199,26 @@ def validate_item_search_ids(
r_session=r_session,
)

items = body.get("features") # type: ignore
if items and len(items) >= 2:
_validate_search_ids_with_ids(
search_url, [items[0].get("id")], methods, errors, r_session
)
_validate_search_ids_with_ids(
search_url,
[items[0].get("id"), items[1].get("id")],
methods,
errors,
r_session,
)
_validate_search_ids_with_ids(
search_url, [i["id"] for i in items], methods, errors, r_session
)
if not body:
errors += f"[{Context.ITEM_SEARCH}] GET Search body was empty"
else:
warnings += f"[{Context.ITEM_SEARCH}] GET Search with no parameters returned < 2 results"
items = body.get("features") # type: ignore
if items and len(items) >= 2:
_validate_search_ids_with_ids(
search_url, [items[0].get("id")], methods, errors, r_session
)
_validate_search_ids_with_ids(
search_url,
[items[0].get("id"), items[1].get("id")],
methods,
errors,
r_session,
)
_validate_search_ids_with_ids(
search_url, [i["id"] for i in items], methods, errors, r_session
)
else:
warnings += f"[{Context.ITEM_SEARCH}] GET Search with no parameters returned < 2 results"


def validate_item_search_ids_does_not_override_all_other_params(
Expand All @@ -3236,7 +3239,7 @@ def validate_item_search_ids_does_not_override_all_other_params(
content_type=geojson_mt,
r_session=r_session,
)
if body.get("features"): # type: ignore
if body and body.get("features"): # type: ignore
_validate_search_ids_with_ids_no_override(
search_url,
body["features"][0],
Expand Down
Loading