Skip to content

Conversation

@mo-dkrz
Copy link
Contributor

@mo-dkrz mo-dkrz commented Mar 13, 2025

Related Issue(s):
It's not an issue. We simply want to support python 3.13 in stac_fastapi.core via removing type_extension!

Description:
It;s gonna close issue #335 as well

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@mo-dkrz
Copy link
Contributor Author

mo-dkrz commented Mar 13, 2025

Dear @jamesfisher-geo and @jonhealy1
Do I need to change the version to be able publish the pypi?

@jonhealy1
Copy link
Collaborator

Hi @mo-dkrz. I will update on pypi.

@jonhealy1 jonhealy1 self-requested a review March 14, 2025 02:33
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mo-dkrz looks great.

  1. We should add python 3.13 to the three setup.py files here, for example:

    "Programming Language :: Python :: 3.12",
    .

  2. Also, can you add an entry to the changelog for these changes? Just add an entry in the Untitled section and then when this pr is approved, I will push a new version to pypi. Thank you.

@mo-dkrz mo-dkrz requested a review from jonhealy1 March 14, 2025 06:56
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work thank you

@jonhealy1 jonhealy1 merged commit 911dbef into stac-utils:main Mar 14, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants