Enabling asset indexing #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rch into unique_asset_names
…ch into unique_asset_names
rhysrevans3
requested review from
jonhealy1 and
jamesfisher-geo
and removed request for
jonhealy1
jamesfisher-geo
approved these changes
Sep 3, 2025
Added a ticket to track unit tests here: #425 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There are a number of extensions that include extra fields within an Item's assets. It would be useful to allow users to filter items based on these fields.
Mapping assets from an Object to a Array of Objects prevents "mapping explosion" from asset keys without needing to disable indexing on the assets.
It does have some search implications. See first "note" here.
PR Checklist:
pre-commit run --all-files)make test)