-
Notifications
You must be signed in to change notification settings - Fork 31
Update stac-fastapi parent libraries to 5.1.1 #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 20 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
268c161
change from 'docker-compose'
jonhealy1 4cbb4e6
remove 'version'
jonhealy1 a93608d
update stac-fastapi tp 5.1
jonhealy1 e06f8c0
change format datetime function
jonhealy1 893ed7f
alias not working?
jonhealy1 605533b
update core to v4.0.0
jonhealy1 c020469
pin stac-fastapi to 5.1.1
jonhealy1 cf4fca0
try no-cache-dir
jonhealy1 b93e0ef
comment out cache
jonhealy1 a21b8c8
remove python 3.8
jonhealy1 a1f0770
fix tests
jonhealy1 d9a8502
fix filter extension
jonhealy1 2c2bd42
update changelog
jonhealy1 ba11623
add cache back
jonhealy1 55a36d3
switch back to filter-lang
jonhealy1 64a238d
change type to str
jonhealy1 4688ab3
add context
jonhealy1 1de9ba5
changelog fix
jonhealy1 3325672
add more info to changelog
jonhealy1 6ada768
change version to 4.0.0a0
jonhealy1 7ded416
improve datetime range
jonhealy1 8b32ba8
update date format logic, test
jonhealy1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| version: '3.9' | ||
|
|
||
| services: | ||
| app-elasticsearch: | ||
| container_name: stac-fastapi-es | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| """library version.""" | ||
| __version__ = "3.2.5" | ||
| __version__ = "4.0.0a0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
stac_fastapi/elasticsearch/stac_fastapi/elasticsearch/version.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| """library version.""" | ||
| __version__ = "3.2.5" | ||
| __version__ = "4.0.0a0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| """library version.""" | ||
| __version__ = "3.2.5" | ||
| __version__ = "4.0.0a0" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change caused by a change to stac-fastapi? I don't think we want to replace
+01:00explicitly as it could be a different timezone. Something like this would workThere's also some code in stac-fastapi that could help https://github.com/stac-utils/stac-fastapi/blob/main/stac_fastapi/types/stac_fastapi/types/rfc3339.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch here. This is a change from stac-fastapi where the get search method now accepts a string as input instead of a tuple. Let me know what you think of the new change. I was having troubles going from string to datetime object back to string and then I was wondering if it's worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good! One question though if a user searches for a datetime that includes a timezone like
2001-01-01T01:01:01+01:00should the search actually be on2001-01-01T00:01:01Zor maybe add one hour? Or is it okay just to strip that off?If it does changes the search I think it's better to let
datetimehandle the timezones. We could userfc3339_str_to_datetimefrom stac-fastapi to handle the string to datetime conversion. As the Item search spec states that datetimes should be formatted to that standard.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. I have updated the code. I also had to update a test - let me know if it looks ok. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great!