fix: Add id field to sort config for consisteny pagination #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pagination does not work correctly for rel: `next` section in /search endpoint of the returned product list. This commit adds id parameter to sorting so that token obtains a unique value.
YuriZmytrakov
force-pushed
the
CAT-1380
branch
from
a241b3e to
8d7393a
Compare
@jonhealy1 thank you for reviewing. This is ready for approval and merging. |
jonhealy1
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The pagination does not work correctly for rel:
nextsection in /search endpoint of the returned product list. This commit adds id parameter to sorting so that token obtains a unique value.PR Checklist:
pre-commit run --all-files)make test)