Ensure Normalize func preserves milliseconds precision #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriZmytrakov
force-pushed
the
CAT-1413
branch
8 times, most recently
from
bfb3c1a to
cd5290e
Compare
YuriZmytrakov
changed the title
YuriZmytrakov
force-pushed
the
CAT-1413
branch
2 times, most recently
from
c62a9d0 to
68af7ab
Compare
Normalize function for datetime strings did not preserve milliseconds, causing the `/search` endpoint return incorrect results. This change ensures that milliseconds are retained when normalized.
YuriZmytrakov
force-pushed
the
CAT-1413
branch
from
68af7ab to
6c0c60a
Compare
YuriZmytrakov
force-pushed
the
CAT-1413
branch
from
2f94935 to
cf256e9
Compare
YuriZmytrakov
added a commit
to YuriZmytrakov/stac-fastapi-elasticsearch-opensearch
that referenced
this pull request
Sep 15, 2025
**Description:** Fixes an issue in the OS STAC `/search` endpoint where datetime filters overwrite milliseconds. The queries return products outside the specified range because the filter was rounding datetimes to full seconds. This change ensures that milliseconds are preserved, so datetime filtering returns correct results. **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [x] Tests pass (run `make test`) - [ ] Documentation has been updated to reflect changes, if applicable - [x] Changes are added to the changelog --------- Co-authored-by: Yuri Zmytrakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes an issue in the OS STAC
/searchendpoint where datetime filters overwrite milliseconds. The queries return products outside the specified range because the filter was rounding datetimes to full seconds. This change ensures that milliseconds are preserved, so datetime filtering returns correct results.PR Checklist:
pre-commit run --all-files)make test)