-
Notifications
You must be signed in to change notification settings - Fork 31
Adding backwards compatibility for asset indexing #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rch into unique_asset_names
…ch into unique_asset_names
Adding scripts for reindexing existing indexes. Adding tests for serializers.
…ch into unique_asset_names
|
Hi @rhysrevans3, can you split this work into 2 separate prs. I think with testing the optional asset indexing, it's a little tricky because the indexes are created when the container starts. |
|
Hi @jonhealy1 I've removed the serializer tests I will create a new pull request for these. I've not had time to test the new environment variable yet. I'll aim to test it early next week. |
|
@rhysrevans3 Ok great thank you |
…ch into unique_asset_names
|
@jonhealy1 this is ready for review. I've not been able to test the reindexing script with the new datetime indexing as I don't have any indexes using it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work thanks @rhysrevans3
**Related Issue(s):** - ~stac-utils#425~ - stac-utils#428 **Description:** - Adds flag for indexing assets. - ~Adds tests for serializers.~ - Adds scripts for reindexing for mapping changes. **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [ ] Tests pass (run `make test`) - [ ] Documentation has been updated to reflect changes, if applicable - [ ] Changes are added to the changelog
**Related Issue(s):** - ~stac-utils#425~ - stac-utils#428 **Description:** - Adds flag for indexing assets. - ~Adds tests for serializers.~ - Adds scripts for reindexing for mapping changes. **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [ ] Tests pass (run `make test`) - [ ] Documentation has been updated to reflect changes, if applicable - [ ] Changes are added to the changelog
Related Issue(s):
Add unit tests for the ItemSerializer and CollectionSerializer #425Description:
Adds tests for serializers.PR Checklist:
pre-commit run --all-files)make test)