You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description:
This is a pretty simple addition but it is dependent on the next release of pgstac (the pgstac-side changes were added in stac-utils/pgstac#295) so the new test will fail until we decide how to conditionally activate this feature. Would it make sense to only activate this extension if the pgstac version is >0.9.1?
The q parameter should probably never be used in an item search because it will probably slow things down a lot, but it is very useful for the collection search function.
PR Checklist:
pre-commit hooks pass locally
Tests pass (run make test)
Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
Now that pgstac 0.9.2 is released (with support for the q free-text parameter) I wanted to kick the tires on this PR! The tests will only pass if we are running pgstac >= 0.9.2 so I'm not exactly sure what that means for releasing this feature.
The q parameter should probably never be used in an item search because it will probably slow things down a lot, but it is very useful for the collection search function.
@hrodmn should we then remove it from the extensions_map list ?
should we then remove it from the extensions_map list ?
Yes, I think removing it from the list of item search extensions by default is the way to go. Users could add it in custom applications if it would be helpful. It's all supported in core.py so I should add some tests to make sure it is working correctly.
Update: Actually free-text for item search is not really supported because pgstac will only search through the description, title, and keywords fields which are not even in the STAC item spec. I will remove the q parameter from the item search request methods to avoid confusing people.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
This is a pretty simple addition but it is dependent on the next release of pgstac (the pgstac-side changes were added in stac-utils/pgstac#295) so the new test will fail until we decide how to conditionally activate this feature. Would it make sense to only activate this extension if the
pgstacversion is >0.9.1?The
qparameter should probably never be used in an item search because it will probably slow things down a lot, but it is very useful for the collection search function.PR Checklist:
pre-commithooks pass locallymake test)make docs)