Skip to content

Fix next, prev link href #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix next, prev link href #164

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b180aee
fix next, prev link href
smohiudd Oct 24, 2024
4174f57
use base_url for paging links
smohiudd Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions stac_fastapi/pgstac/models/links.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ def link_next(self) -> Optional[Dict[str, Any]]:
if self.next is not None:
method = self.request.method
if method == "GET":
href = merge_params(self.url, {"token": f"next:{self.next}"})
url = self.resolve(f"collections/{self.collection_id}/items")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 it seems that PagingLinks class is not only used in the /items endpoint but also in the all_collections method

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I missed that. I guess that change is not going to work then

href = merge_params(url, {"token": f"next:{self.next}"})
link = {
"rel": Relations.next.value,
"type": MimeTypes.geojson.value,
Expand All @@ -154,7 +155,8 @@ def link_prev(self) -> Optional[Dict[str, Any]]:
if self.prev is not None:
method = self.request.method
if method == "GET":
href = merge_params(self.url, {"token": f"prev:{self.prev}"})
url = self.resolve(f"collections/{self.collection_id}/items")
href = merge_params(url, {"token": f"prev:{self.prev}"})
return {
"rel": Relations.previous.value,
"type": MimeTypes.geojson.value,
Expand Down
Loading