fallback to all_collections when CollectionSearchExtension is not enabled#179
Merged
vincentsarago merged 2 commits intopatch/collection-search-pagingfrom Jan 10, 2025
Conversation
hrodmn
approved these changes
Jan 10, 2025
Collaborator
There was a problem hiding this comment.
Yikes, good catch @vincentsarago. Where is the default limit of 10 being set? Is that in stac-fastapi or in pgstac? Could we just set the default limit to 10000 in stac-fastapi-pgstac to avoid the pgstac limit?
Member
Author
|
@hrodmn yeah the limit comes from pgstac https://github.com/stac-utils/pgstac/blob/6da165b7c4f6da321d0b58bbb78da2887763a0d8/src/pgstac/sql/004a_collectionsearch.sql#L88
That could be a possibility as well, but what if there are 10001 collections? 😅 I feel it's not up to us to define how many collections |
vincentsarago
added a commit
that referenced
this pull request
Jan 13, 2025
* add failing test * handle collection paging differently (#156) * handle collection paging differently * test next link * add OffsetPaginationExtension * uncomment test * update to pgstac 0.9.2 * update prev logic * only test 0.9.0 * update pypstac version * add back 0.8 support but allow skip tests * skip for 0.8 * remove warnings * fallback to all_collections when `CollectionSearchExtension` is not enabled (#179) * fallback to all_collections when `CollectionSearchExtension` is not enabled * test all_collection fallback * add offset=0 * Update tests/conftest.py Co-authored-by: Henry Rodman <henry.rodman@gmail.com> --------- Co-authored-by: Henry Rodman <henry.rodman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #155 (comment)