Skip to content

Conversation

@hrodmn
Copy link
Collaborator

@hrodmn hrodmn commented Mar 4, 2025

Related Issue(s):

Description:

Move the Postgres settings out of the main Settings class into a separate PostgresSettings class, then defer loading the Postgres settings until connecting to the database

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@hrodmn hrodmn marked this pull request as draft March 4, 2025 18:29
@hrodmn hrodmn force-pushed the patch/optional-postgres-settings branch from 7bf94c4 to 2b9d2ec Compare March 5, 2025 17:54
@hrodmn hrodmn requested a review from vincentsarago March 5, 2025 17:54
@hrodmn hrodmn marked this pull request as ready for review March 5, 2025 17:54
@hrodmn hrodmn force-pushed the patch/optional-postgres-settings branch from 737f76a to a8ed942 Compare March 5, 2025 19:22
@hrodmn hrodmn force-pushed the patch/optional-postgres-settings branch from a8ed942 to ad080fb Compare March 5, 2025 19:38
@hrodmn hrodmn changed the title make postgres settings values optional (but validate later) move Postgres settings into separate settings class Mar 5, 2025
@vincentsarago vincentsarago merged commit 674b1ee into main Mar 10, 2025
7 checks passed
@vincentsarago vincentsarago deleted the patch/optional-postgres-settings branch March 10, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot load app module without setting Postgres environment variables

2 participants