Skip to content

reduce the min number of db conn #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2025
Merged

reduce the min number of db conn #222

merged 3 commits into from
Apr 7, 2025

Conversation

@vincentsarago
Copy link
Member

closes #219

@vincentsarago vincentsarago requested review from bitner and hrodmn April 3, 2025 21:44
hrodmn
hrodmn approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@hrodmn hrodmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense as a default setting for this application but I will have to investigate how it interacts with pgbouncer in eoapi-cdk.

@vincentsarago
Copy link
Member Author

@hrodmn in eoapi-cdk we set the min/max db conn to 1 because each lambda function will be used only by one request

@bitner
Copy link
Collaborator

bitner commented Apr 7, 2025

With pgbouncer, min/max db conn should just be 1 as pgbouncer will be managing any pooling.

@vincentsarago vincentsarago merged commit 34d0fad into main Apr 7, 2025
7 checks passed
@vincentsarago vincentsarago deleted the patch/reduce-min-db-conn branch April 7, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitner bitner bitner approved these changes

@hrodmn hrodmn hrodmn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

reduce min connection to 1

3 participants

@vincentsarago @bitner @hrodmn