Skip to content

ignore 'rel:items' entries when generating links #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2025
Merged

ignore 'rel:items' entries when generating links #294

merged 2 commits into from
Sep 30, 2025

Conversation

@fmigneault
Copy link
Contributor

@fmigneault fmigneault commented Sep 26, 2025 •
edited
Loading

Related Issue(s):

Description:

Filters the rel:items links to return only the self-resolved one.

Fix applied via our own implementation for demo: crim-ca/stac-app#48
Result is properly filtered: https://hirondelle.crim.ca/stac/collections/ (no more http:/stac:8000/... links)

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

fmigneault added a commit to crim-ca/stac-app that referenced this pull request Sep 26, 2025
@fmigneault
apply patch rel:items links (stac-utils/stac-fastapi-pgstac#294)
7c93493
@fmigneault fmigneault mentioned this pull request Sep 26, 2025
Merged
@fmigneault
Copy link
Contributor Author

fmigneault commented Sep 26, 2025 •
edited
Loading

@gadomski
please review :)
a new release including this fix would be welcomed so I can tag it on our end

@gadomski gadomski self-requested a review September 29, 2025 14:38
gadomski
gadomski requested changes Sep 30, 2025
View reviewed changes
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include a regression unit test? Thanks!

I'm also going to request an additional review from the last person to touch this code, just to ensure this omission wasn't intentional.

@gadomski gadomski requested a review from bitner September 30, 2025 12:00
@vincentsarago vincentsarago self-requested a review September 30, 2025 13:21
@vincentsarago
Copy link
Member

thanks @fmigneault 🙏

@gadomski Considering the issue was reported in stac-fastapi and the same fix was applied, I'm going to merge and make a new release

@vincentsarago vincentsarago merged commit 75b57e9 into stac-utils:main Sep 30, 2025
7 checks passed
This was referenced Sep 30, 2025
Merged
Merged
@vprivat-ads vprivat-ads mentioned this pull request Sep 30, 2025
Closed
fmigneault added a commit to bird-house/birdhouse-deploy that referenced this pull request Oct 1, 2025
@fmigneault
update stac-app 2.0.2 to fix rel:items links (#590)
a63786e 
## Overview

Update STAC API

## Changes

**Non-breaking changes**
- n/a

**Breaking changes**
- STAC: Update default API version to `crim-ca/stac-app:2.0.2`.
  - Fix `rel: items` links causing invalid collection listing results

## Related Issue / Discussion

- stac-utils/stac-fastapi-pgstac#294
- stac-utils/stac-fastapi-pgstac#285
- crim-ca/stac-populator#109
- crim-ca/stac-app#50

## CI Operations


birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gadomski gadomski gadomski requested changes

@vincentsarago vincentsarago vincentsarago approved these changes

@bitner bitner Awaiting requested review from bitner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should special links be omitted during ingestion? CollectionLinks does not handle rel: items

3 participants

@fmigneault @vincentsarago @gadomski