Skip to content

Conversation

@vincentsarago
Copy link
Member

closes #297

cc @batpad

@vincentsarago vincentsarago requested review from gadomski and hrodmn and removed request for gadomski October 1, 2025 14:09
Copy link
Collaborator

@hrodmn hrodmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I just wonder if we should throw an error if the user specifies cors_origins=("*",) (by default or not) and cors_origin_regex is not None.

@vincentsarago vincentsarago requested a review from hrodmn October 2, 2025 10:48
@vincentsarago vincentsarago merged commit b8bf962 into main Oct 3, 2025
7 checks passed
@vincentsarago vincentsarago deleted the feature/add-cors-regex branch October 3, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow for configuration of allow_origin_regex for CORS settings

3 participants