Made use of BulkTransactionsClient easily overridable#24
Open
keul wants to merge 1 commit intostac-utils:mainfrom
Open
Made use of BulkTransactionsClient easily overridable#24keul wants to merge 1 commit intostac-utils:mainfrom
keul wants to merge 1 commit intostac-utils:mainfrom
Conversation
keul
force-pushed
the
prevent-bulkclient-shadow-usage
branch
from
abc1a09 to
ef48ab3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Migrated from stac-utils/stac-fastapi#559
Currently is quite easy to extend the stac_fastapi.sqlalchemy package to be connectes to custom database structure.
This can be done by OOP inheritance and is working well.
One of the customisation I did in my project is the use of custom TransactionsClient and BulkTransactionsClient. 90% of the original code is OK, I just need to change some class-levels attributes (new ORM models, etc).
Then I found that TransactionsClient is internally using an hardcoded reference to BulkTransactionsClient.
https://github.com/stac-utils/stac-fastapi-sqlalchemy/blob/main/stac_fastapi/sqlalchemy/transactions.py#L49
This force me to re-define the
create_itemin my subclass to just change one line.The PR is just making this reference easier to be overridden.
PR Checklist:
pre-commithooks pass locallymake test) some tests are failing, but also in the current mastermake docs)