use pydantic settings #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Apr 11, 2024
| stac_fastapi_title: str = "stac-fastapi" | ||
| stac_fastapi_description: str = "stac-fastapi" | ||
| stac_fastapi_version: str = "0.1" | ||
| stac_fastapi_landing_id: str = "stac-fastapi" |
There was a problem hiding this comment.
as discussed in #639 I think it makes more sense for this variable to be named landing_id
vincentsarago
commented
Apr 11, 2024
| stac_fastapi_title: str = "stac-fastapi" | ||
| stac_fastapi_description: str = "stac-fastapi" | ||
| stac_fastapi_version: str = "0.1" | ||
| stac_fastapi_landing_id: str = "stac-fastapi" |
There was a problem hiding this comment.
I've also reverted to stac-fastapi default as it was before
There was a problem hiding this comment.
Looks good to me. The version is the version number of the User's stac_fastapi, not this version ie. soon to be 2.5.0
|
#657 @jonhealy1 could you check with the latest change 🙏 @m-mohr I'll wait for your 👍 |
vincentsarago
added a commit
that referenced
this pull request
Apr 11, 2024
* Allow an easy way to configure the landing page id, description, title and version via env variables * use pydantic settings (#657) * use pydantic settings * rename stac_fastapi_id to stac_fastapi_landing_id * Update docs/src/tips-and-tricks.md --------- Co-authored-by: vincentsarago <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposed changed for #639
This PR is moving the env configuration into
ApiSettings