keep datetime as string type in GET Request models #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
reviewed
Jan 14, 2025
vincentsarago
commented
Jan 15, 2025
| datetime: Optional[DateTimeType] = attr.ib( | ||
| default=None, converter=_datetime_converter | ||
| ) | ||
| datetime: DateTimeQueryType = attr.ib(default=None, validator=_validate_datetime) |
There was a problem hiding this comment.
Technically we didn't had to add datetime attribute here, but we do it to keep the order of the attributes the same as before (mostly for openapi docs 🤷♂️)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
/searching by date and/or datetime and/or datetime+ms #778Description:
This PR change the
typefor the datetime parameter in GET request for/search,/collectionand/itemsendpoints.with this change, The GET and POST request models behave similarly by setting type for
string.