Skip to content

Conversation

@vincentsarago
Copy link
Member

No description provided.

install_requires = [
"brotli_asgi",
"stac-fastapi.types~=3.0",
"stac-fastapi.types~=3.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gadomski I'd love to have your objective opinion on this

Because 3.1 introduces breaking changes (filter -> filter_expr and datetime type) should we:

  • make a 4.0 instead
  • set api and extensions dependencies to >=3.1,<4.0
  • set api and extensions dependencies to ==3.1.*

ref: #678

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 tricky one. This repo is like halfway between a library and an application (in my head) which makes versioning weird. I'm a bit more inclined to just go for a 4.0 even though there isn't too much in it ... versions are cheap and at least we'll surprise other folks less when their code breaks?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, looking at https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/blob/main/CHANGELOG.md makes me also think we should do 4.0 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants