Skip to content

Patch/add titles in links #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2025
+20 −6
Merged

Patch/add titles in links #805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bec895
defined links title in landing page
vincentsarago Mar 3, 2025
8327d5f
update changelog
vincentsarago Mar 3, 2025
1560cc9
fix
vincentsarago Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## [Unreleased]

### Added

- titles in `Landing` page links

### Changed

- remove `child` links (`collections`) in landing page response
Expand Down
8 changes: 6 additions & 2 deletions stac_fastapi/api/tests/test_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,9 @@ def get_search(
)

assert landing.status_code == 200, landing.text
assert "Queryables" in [link.get("title") for link in landing.json()["links"]]
assert "Queryables available for this Catalog" in [
link.get("title") for link in landing.json()["links"]
]
assert get_search.status_code == 200, get_search.text
assert post_search.status_code == 200, post_search.text

Expand Down Expand Up @@ -221,7 +223,9 @@ def get_search(
)

assert landing.status_code == 200, landing.text
assert "Queryables" in [link.get("title") for link in landing.json()["links"]]
assert "Queryables available for this Catalog" in [
link.get("title") for link in landing.json()["links"]
]
assert get_search.status_code == 200, get_search.text
assert post_search.status_code == 200, post_search.text

Expand Down
3 changes: 3 additions & 0 deletions stac_fastapi/api/tests/test_app_prefix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ def test_api_prefix(TestCoreClient, prefix):

link_tests = [
("root", "application/json", "/"),
("self", "application/json", "/"),
("conformance", "application/json", "/conformance"),
("data", "application/json", "/collections"),
("search", "application/geo+json", "/search"),
Expand Down Expand Up @@ -126,6 +127,7 @@ def test_async_api_prefix(AsyncTestCoreClient, prefix):

link_tests = [
("root", "application/json", "/"),
("self", "application/json", "/"),
("conformance", "application/json", "/conformance"),
("data", "application/json", "/collections"),
("search", "application/geo+json", "/search"),
Expand Down Expand Up @@ -190,6 +192,7 @@ def test_api_prefix_with_root_path(TestCoreClient, prefix):

link_tests = [
("root", "application/json", "/"),
("self", "application/json", "/"),
("conformance", "application/json", "/conformance"),
("data", "application/json", "/collections"),
("search", "application/geo+json", "/search"),
Expand Down
11 changes: 7 additions & 4 deletions stac_fastapi/types/stac_fastapi/types/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,16 +289,19 @@ def _landing_page(
{
"rel": Relations.self.value,
"type": MimeTypes.json.value,
"title": "This document",
"href": base_url,
},
{
"rel": Relations.root.value,
"type": MimeTypes.json.value,
"title": "Root",
"href": base_url,
},
{
"rel": Relations.data.value,
"type": MimeTypes.json.value,
"title": "Collections available for this Catalog",
"href": urljoin(base_url, "collections"),
},
{
Expand All @@ -310,14 +313,14 @@ def _landing_page(
{
"rel": Relations.search.value,
"type": MimeTypes.geojson.value,
"title": "STAC search",
"title": "STAC search [GET]",
"href": urljoin(base_url, "search"),
"method": "GET",
},
{
"rel": Relations.search.value,
"type": MimeTypes.geojson.value,
"title": "STAC search",
"title": "STAC search [POST]",
"href": urljoin(base_url, "search"),
"method": "POST",
},
Expand Down Expand Up @@ -391,7 +394,7 @@ def landing_page(self, **kwargs) -> stac.LandingPage:
{
"rel": Relations.queryables.value,
"type": MimeTypes.jsonschema.value,
"title": "Queryables",
"title": "Queryables available for this Catalog",
"href": urljoin(base_url, "queryables"),
}
)
Expand Down Expand Up @@ -601,7 +604,7 @@ async def landing_page(self, **kwargs) -> stac.LandingPage:
{
"rel": Relations.queryables.value,
"type": MimeTypes.jsonschema.value,
"title": "Queryables",
"title": "Queryables available for this Catalog",
"href": urljoin(base_url, "queryables"),
"method": "GET",
}
Expand Down
Loading