improve typing #826
Merged
improve typing #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Apr 17, 2025
| "from": NotRequired[Union[int, float]], | ||
| "to": NotRequired[Optional[Union[int, float]]], | ||
| }, | ||
| ) |
There was a problem hiding this comment.
I didn't caught that when reviewing the original PR but it was defining a type: TypedDict with Pydantic field 🤷
vincentsarago
commented
Apr 17, 2025
stac_fastapi/extensions/stac_fastapi/extensions/core/collection_search/request.py
Outdated
Show resolved
Hide resolved
vincentsarago
commented
Apr 17, 2025
stac_fastapi/extensions/stac_fastapi/extensions/core/collection_search/request.py
Outdated
Show resolved
Hide resolved
vincentsarago
commented
Apr 17, 2025
stac_fastapi/extensions/stac_fastapi/extensions/core/filter/request.py
Outdated
Show resolved
Hide resolved
vincentsarago
commented
Apr 17, 2025
stac_fastapi/extensions/stac_fastapi/extensions/core/query/request.py
Outdated
Show resolved
Hide resolved
vincentsarago
commented
Apr 17, 2025
stac_fastapi/extensions/stac_fastapi/extensions/core/sort/request.py
Outdated
Show resolved
Hide resolved
…o patch/improve-typing
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #814
Note:
in https://github.com/stac-utils/stac-fastapi/blob/main/CONTRIBUTING.md we says we run
mypyduring pre-commit but it's not true. The lib is not type checked 😓I've ran mypy locally but it returns to many complex errors. I've fixed some with this PR but I'm going to open an issue about to plan a bigger chunk of work on type hints