move Search field validators outside model #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Mar 18, 2025
| "Maximum elevation must greater than minimum elevation" | ||
| ) | ||
| else: | ||
| raise ValueError("Bounding box must have 4 or 6 coordinates") |
There was a problem hiding this comment.
This will not be called normally because pydantic will already check if the inputs are tuple of 4 or 6 values. But I think if we want to re-use the validator outside pydantic model (e.g in stac-fastapi) it will be useful
vincentsarago
commented
Mar 18, 2025
| for v in values | ||
| ], | ||
| ) | ||
| return dates |
There was a problem hiding this comment.
extract the parsing function in order to re-use it and get rid of https://github.com/stac-utils/stac-fastapi/blob/main/stac_fastapi/types/stac_fastapi/types/rfc3339.py 🙈
gadomski
requested changes
Mar 19, 2025
Co-authored-by: Pete Gadomski <[email protected]>
gadomski
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does:
move
bboxanddatetimevalidator outside the Search class (so we can re-use them in https://github.com/stac-utils/stac-fastapi/blob/main/stac_fastapi/types/stac_fastapi/types/search.py#L150-L210)remove Search private attribute (_start/_end datetime) in order to do ☝️. The
start_datetimeandend_datetimeproperties are still available, but now we will dynamically process them (parse datetime and return the value). This is a small performance drawback.... but I don't think many users use those properties (we could make them cached_properties in the future, or use lru_cache to cache the datetime parsing