Skip to content

Map enhancements: add visitor arg to ::expose() with overloads, rename overload_base_get_item_for_std_map #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 26, 2024
Merged

Map enhancements: add visitor arg to ::expose() with overloads, rename overload_base_get_item_for_std_map #507

merged 7 commits into from
Sep 26, 2024

Conversation

@ManifoldFR
Copy link
Member

@ManifoldFR ManifoldFR commented Sep 23, 2024 •
edited
Loading

Also:

  • split GenericMapPythonVisitor into its own file eigenpy/map.hpp
  • move EmptyPythonVisitor to its own header file eigenpy/utils/empty-visitor
  • rename overload_base_get_item_for_std_map to drop the std mention, move out of eigenpy::details namespace

Resolves #506

@ManifoldFR ManifoldFR requested a review from jorisv September 23, 2024 10:48
@ManifoldFR
Copy link
Member Author

ManifoldFR commented Sep 23, 2024 •
edited
Loading

@edantec can you please compile this branch to see if it resolves Simple-Robotics/aligator/issues/209 when you use the eigenpy::overload_base_get_item_for_map visitor ?

@ManifoldFR ManifoldFR changed the title Map enhancements: add visitor arg to ::expose() with overloads Map enhancements: add visitor arg to ::expose() with overloads, rename overload_base_get_item_for_std_map Sep 23, 2024
ManifoldFR added a commit to Simple-Robotics/aligator that referenced this pull request Sep 23, 2024
@ManifoldFR
[python] CostStack : use overload_base_get_item_for_map
f8146a3 
This commit requires stack-of-tasks/eigenpy#507 to be merged.
ManifoldFR added a commit to Simple-Robotics/aligator that referenced this pull request Sep 23, 2024
@ManifoldFR
[python] CostStack : use overload_base_get_item_for_map
09d5437 
This commit requires stack-of-tasks/eigenpy#507 to be merged.

Resolves #209
@edantec
Copy link
Contributor

edantec commented Sep 23, 2024

@edantec can you please compile this branch to see if it resolves Simple-Robotics/aligator/issues/209 when you use the eigenpy::overload_base_get_item_for_map visitor ?

Done, everything is working well

@ManifoldFR
Copy link
Member Author

ManifoldFR commented Sep 23, 2024

@edantec can you please compile this branch to see if it resolves Simple-Robotics/aligator/issues/209 when you use the eigenpy::overload_base_get_item_for_map visitor ?

Done, everything is working well

note: it ended up not working for std::pair, which can't be returned by reference unless we expose them by class
😅

jorisv
jorisv requested changes Sep 25, 2024
View reviewed changes
@ManifoldFR ManifoldFR requested a review from jorisv September 25, 2024 15:47
@jcarpent jcarpent force-pushed the topic/map-enhancements branch from b8fe774 to e03f6b2 Compare September 26, 2024 09:17
@ManifoldFR ManifoldFR merged commit 9608a04 into stack-of-tasks:devel Sep 26, 2024
34 checks passed
@ManifoldFR ManifoldFR deleted the topic/map-enhancements branch September 26, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisv jorisv jorisv approved these changes

@jcarpent jcarpent jcarpent approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ManifoldFR @edantec @jorisv @jcarpent