Ensure symbols are correctly exported on Windows #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for merging @nim65s ! There is no hurry on my side, but when you have time it would be great to also have a new release with these fixes, thanks! |
|
On it :) |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixes in #64 were not the only one actually required to build and use the library with
-DBUILD_SHARED_LIBS:BOOL=ONon Windows, with the fixes on this PR I am actually able to run all the testsuite on Windows while building the library with-DBUILD_SHARED_LIBS:BOOL=ON.The fixes are:
EIQUADPROG_DLLAPItestabshared library with withWINDOWS_EXPORT_ALL_SYMBOLSDESTINATION libargument passed toinstall(TARGETS <...>), to ensure that the default value ofDESTINATIONare used, that are the correct one also on Windows (i.e.libforLIBRARYandARCHIVEandbinforRUNTIME).Sorry for the delay w.r.t. to #64, I initially overlooked this as I thought symbols were exported here with
WINDOWS_EXPORT_ALL_SYMBOLS.