Skip to content

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Oct 23, 2024

Description

Some cases have been migrated to PartialObjectMeta instead where only the metadata is used anyway.

Part of stackabletech/issues#211. Fixes #237.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

Some cases have been migrated to PartialObjectMeta instead where only
the metadata is used anyway.

Part of stackabletech/issues#211. Fixes #237.
Instead of requesting it but throwing it away.
@nightkr nightkr requested review from a team and razvan October 23, 2024 13:13
razvan
razvan previously approved these changes Oct 24, 2024
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nightkr nightkr added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit ee83f52 Oct 24, 2024
31 checks passed
@nightkr nightkr deleted the feature/deserializeguard branch October 24, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

STS restarter should only watch secret/cm metadata

4 participants