Skip to content

Conversation

@NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Apr 9, 2025

Description

Use Tracing::pre_configured from stackable-telemetry

Breaking changes:

operator-binary

  • The console log level was set by COMMONS_OPERATOR_LOG, and is now set by CONSOLE_LOG.
  • The file log level was set by COMMONS_OPERATOR_LOG, and is now set by FILE_LOG.
  • The file log directory was previously changed to ROLLING_LOGS, but has been updated to ROLLING_LOGS_DIR.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

BREAKING: The console log level, file log level and directory variables have been changed
@NickLarsenNZ NickLarsenNZ requested a review from Techassi April 9, 2025 11:00
@NickLarsenNZ NickLarsenNZ self-assigned this Apr 9, 2025
@NickLarsenNZ NickLarsenNZ changed the title feat!: Use Tracing::pre_configured from stackable-telemetry feat!: Use Tracing::pre_configured from stackable-telemetry Apr 9, 2025
@Techassi Techassi added this pull request to the merge queue Apr 9, 2025
Merged via the queue into main with commit ec6d17a Apr 9, 2025
17 checks passed
@Techassi Techassi deleted the feat/use-tracing-pre-configured branch April 9, 2025 11:36
@Techassi Techassi moved this to Development: In Review in Stackable Engineering Apr 10, 2025
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Apr 10, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants