Skip to content

chore: Remove workaround for limiting rescheduling delay #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

chore: Remove workaround for limiting rescheduling delay #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,12 @@ All notable changes to this project will be documented in this file.
- Reduce severity of Pod eviction errors. Previously, the operator would produce lot's of
`Cannot evict pod as it would violate the pod's disruption budget` errors. With this fix, the
error is reduced to an info instead ([#372]).
- Remove workaround for limiting rescheduling delay ([#378]).

[#372]: https://github.com/stackabletech/commons-operator/pull/372
[#376]: https://github.com/stackabletech/commons-operator/pull/376
[#377]: https://github.com/stackabletech/commons-operator/pull/377
[#378]: https://github.com/stackabletech/commons-operator/pull/378

## [25.7.0] - 2025-07-23

Expand Down
4 changes: 0 additions & 4 deletions rust/operator-binary/src/restart_controller/pod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,6 @@ async fn reconcile(pod: Arc<PartialObjectMeta<Pod>>, ctx: Arc<Ctx>) -> Result<Ac
}

Some(Ok(time_until_pod_expires)) => {
// Clamp the rescheduling delay to a maximum of 6 months to prevent `Action::requeue` from panicking
// This workaround can be removed once https://github.com/kube-rs/kube/issues/1772 is resolved
let time_until_pod_expires =
time_until_pod_expires.min(Duration::from_secs(6 * 30 * 24 * 60 * 60));
tracing::info!(
pod.expires_at = ?pod_expires_at,
recheck_delay = ?time_until_pod_expires,
Expand Down
Loading