Skip to content

Conversation

razvan
Copy link
Member

@razvan razvan commented Sep 18, 2024

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Will look at pre-commit separately, maybe the next branch needs updating (I have merged main into next).

Question: Why do some yaml files have {% raw %} in them though?

@razvan
Copy link
Member Author

razvan commented Sep 19, 2024

Question: Why do some yaml files have {% raw %} in them though?

That is a very good question. @sbernauer knows maybe ?

@razvan razvan merged commit e5b02d7 into next Sep 19, 2024
2 checks passed
@razvan razvan deleted the chore/nifi-24.11 branch September 19, 2024 09:51
@sbernauer
Copy link
Member

All files stackablectl reads are templated using https://crates.io/crates/tera, so that you can override credentials when installing the demo and such.
If you look at e.g. https://github.com/stackabletech/demos/blob/main/stacks/signal-processing/grafana-dashboards.yaml the contained JSON trips over the Jinja2 (sort of) template, so we basically quote the whole file, so tera does not try to replace {{thing}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants