Skip to content

Conversation

@dervoeti
Copy link
Member

@dervoeti dervoeti commented Mar 18, 2025

Fix for the waterlevel demo.

The actual difference here is that I adapted the query for the measurements_per_day dataset:

It was this:

SELECT FLOOR(__time TO 'day') as __time, count(*) as measurements
FROM "druid"."measurements"
GROUP BY 1

Which was failing with Druid 31.0.1. I'm actually not sure why, but Druid responded with Error parsing near 'TO' at line 1:22. I briefly checked the docs and changelogs and didn't really find a reason why this would not be valid anymore.

However, it's now:

SELECT TIME_FLOOR("__time", 'P1D') AS __time, COUNT(*) AS measurements
FROM "druid"."measurements"
GROUP BY 1

which works fine.

To see the actual diff, the zip file need to be unpacked and compared to the content of the current archive.

@dervoeti dervoeti force-pushed the fix/waterlevel-druid-syntax branch from 39398f6 to d3bad6e Compare March 18, 2025 17:01
@dervoeti dervoeti moved this to Development: Waiting for Review in Stackable Engineering Mar 18, 2025
@dervoeti dervoeti self-assigned this Mar 18, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is unfortunate that we have to restore superset via zip :/

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 19, 2025
@dervoeti dervoeti added this pull request to the merge queue Mar 19, 2025
@dervoeti dervoeti moved this from Development: In Review to Development: Done in Stackable Engineering Mar 19, 2025
Merged via the queue into main with commit 6e1dcba Mar 19, 2025
2 checks passed
@dervoeti dervoeti deleted the fix/waterlevel-druid-syntax branch March 19, 2025 12:22
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants