Skip to content

Commit d38c369

Browse files
authored
fix: pin luxon to fix 4.1.2 build (#1316)
1 parent bb35a87 commit d38c369

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ All notable changes to this project will be documented in this file.
4949
- hbase: move hbck2.env to hbase-operator-tools image and add log4j2 properties for this tool ([#1300]).
5050
- hbase: replace `sed` calls with `config-utils template` where possible ([#1301]).
5151
- superset: Fix the 4.1.2 build when building from source ([#1309])
52-
- superset: Pin `luxon` to version 3.6.1 to fix build ([#1315])
52+
- superset: Pin `luxon` to version 3.6.1 to fix build ([#1315], [#1316])
5353

5454
### Fixed
5555

@@ -108,6 +108,7 @@ All notable changes to this project will be documented in this file.
108108
[#1309]: https://github.com/stackabletech/docker-images/pull/1309
109109
[#1311]: https://github.com/stackabletech/docker-images/pull/1311
110110
[#1315]: https://github.com/stackabletech/docker-images/pull/1315
111+
[#1316]: https://github.com/stackabletech/docker-images/pull/1316
111112

112113
## [25.7.0] - 2025-07-23
113114

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
1-
From 1b11f3ff47f46105289f7f9dcaa4fc10d6ea3571 Mon Sep 17 00:00:00 2001
1+
From fcff47eb39942ca5699ca31046ac0130da54fee8 Mon Sep 17 00:00:00 2001
22
From: dervoeti <[email protected]>
33
Date: Wed, 22 Oct 2025 17:04:19 +0200
44
Subject: fix: pin luxon to fix build
55

6-
For some reason npm tries to use a newer version of luxon than the version in the lock file. I suspect this might be related to how npm before version 11 handles workspace dependencies in lock files. The luxon version is set to 3.6.1 now to prevent npm from trying to select a newer version, so that the same packages as in the original Superset build are used.
6+
For some reason npm tries to use a newer version of luxon than the version in the lock file. I suspect this might be related to how npm before version 11 handles workspace dependencies in lock files. The luxon version is set to 3.5.0 now to prevent npm from trying to select a newer version, so that the same packages as in the original Superset build are used.
77
---
88
superset-frontend/package.json | 2 +-
99
1 file changed, 1 insertion(+), 1 deletion(-)
1010

1111
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
12-
index ebca197a25..3490ecaa93 100644
12+
index ebca197a25..bb2641a67f 100644
1313
--- a/superset-frontend/package.json
1414
+++ b/superset-frontend/package.json
1515
@@ -148,7 +148,7 @@
1616
"json-bigint": "^1.0.0",
1717
"json-stringify-pretty-compact": "^2.0.0",
1818
"lodash": "^4.17.21",
1919
- "luxon": "^3.5.0",
20-
+ "luxon": "3.6.1",
20+
+ "luxon": "3.5.0",
2121
"mapbox-gl": "^2.10.0",
2222
"markdown-to-jsx": "^7.4.7",
2323
"match-sorter": "^6.3.4",

0 commit comments

Comments
 (0)