Skip to content

Conversation

@maltesander
Copy link
Member

@maltesander maltesander commented Mar 14, 2025

Description

part of #961

REPOSITORY                       TAG                                  IMAGE ID       CREATED         SIZE
oci.stackable.tech/sdp/trino     470-stackable25.3.0-reduced-size-3   bd5a26141ba5   6 minutes ago   1.86GB
oci.stackable.tech/sdp/trino     470-stackable25.3.0                  068a6a858ea1   24 hours ago    6.59GB
  • Does remove the recursive chmod/chown in the final image and attempts non recursive chmod/chown or doing as much as possible in the builder step.
  • removed log4shell checks
  • avoid patches being present in the final image
  • Uses check-permissions-ownership script to validate any wrong permissions / ownership in the /stackable folder (example for nifi)
 => [nifi-2_2_0 final  7/10] RUN <<EOF (microdnf update...)                                                                                                                                         8.2s
 => ERROR [nifi-2_2_0 final  8/10] RUN <<EOF (chmod +x /tmp/check-permissions-ownership...)                                                                                                         0.9s
------
 > [nifi-2_2_0 final  8/10] RUN <<EOF (chmod +x /tmp/check-permissions-ownership...):
0.601 Ownership mismatch:  /stackable/nifi (Expected: 1000:0, Found: 0:0)
0.622 Permission mismatch: /stackable/python (Owner: rwx, Group: r-x)
0.624 Permission mismatch: /stackable/bin (Owner: rwx, Group: r-x)
0.628 Permission mismatch: /stackable/nifi-2.2.0 (Owner: rwx, Group: r-x)
0.843 Permission and Ownership checks failed for /stackable!

@maltesander maltesander self-assigned this Mar 26, 2025
@maltesander maltesander requested a review from a team March 26, 2025 12:13
@maltesander maltesander marked this pull request as ready for review March 26, 2025 12:13
@maltesander maltesander moved this to Development: Waiting for Review in Stackable Engineering Mar 26, 2025
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 26, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but probably worth a CHANGELOG entry

@maltesander
Copy link
Member Author

LGTM, but probably worth a CHANGELOG entry

86163ae

maltesander and others added 2 commits March 26, 2025 13:21
Co-authored-by: Sebastian Bernauer <[email protected]>
@sbernauer sbernauer requested a review from NickLarsenNZ March 26, 2025 12:29
@NickLarsenNZ
Copy link
Member

@maltesander I will leave this for now while you investigate the differences in build sizes on different machines.
Ping me when you'd like another review.

maltesander and others added 2 commits April 7, 2025 13:37
Co-authored-by: Siegfried Weber <[email protected]>
Co-authored-by: Siegfried Weber <[email protected]>
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander maltesander added this pull request to the merge queue Apr 7, 2025
@maltesander maltesander moved this from Development: In Review to Development: Done in Stackable Engineering Apr 7, 2025
Merged via the queue into main with commit 47d35ce Apr 7, 2025
3 checks passed
@maltesander maltesander deleted the fix/trino-reduce-image-size branch April 7, 2025 12:41
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants