Skip to content

Conversation

@dervoeti
Copy link
Member

Description

The "Update FMPP" patch for Druid 31.0.1 creates an unnecessary 10-update-fmpp.patch file (this was probably accidentally introduced when migrating the patches to the Patchable format). This currently causes Patchable to fail during checkout of Druid 31.0.1 (Diff::from_buffer is failing to parse the diff).

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@dervoeti dervoeti requested a review from nightkr March 17, 2025 13:54
@dervoeti dervoeti added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit ae47d9d Mar 17, 2025
3 checks passed
@dervoeti dervoeti deleted the fix/druid-31-fmpp-patch branch March 17, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants