Skip to content

Conversation

@maltesander
Copy link
Member

@maltesander maltesander commented Mar 26, 2025

Description

part of #961

REPOSITORY                              TAG                                   IMAGE ID       CREATED          SIZE
oci.stackable.tech/sdp/druid            31.0.1-stackable25.3.0-reduced-size   f17d5ed72c07   58 seconds ago   1.19GB
oci.stackable.tech/sdp/druid            31.0.1-stackable25.3.0                818953ae9180   31 hours ago     1.85GB
  • Does remove the recursive chmod/chown in the final image and attempts non recursive chmod/chown or doing as much as possible in the builder step.
  • Uses check-permissions-ownership script to validate any wrong permissions / ownership in the /stackable folder (example for nifi)
 => [nifi-2_2_0 final  7/10] RUN <<EOF (microdnf update...)                                                                                                                                         8.2s
 => ERROR [nifi-2_2_0 final  8/10] RUN <<EOF (chmod +x /tmp/check-permissions-ownership...)                                                                                                         0.9s
------
 > [nifi-2_2_0 final  8/10] RUN <<EOF (chmod +x /tmp/check-permissions-ownership...):
0.601 Ownership mismatch:  /stackable/nifi (Expected: 1000:0, Found: 0:0)
0.622 Permission mismatch: /stackable/python (Owner: rwx, Group: r-x)
0.624 Permission mismatch: /stackable/bin (Owner: rwx, Group: r-x)
0.628 Permission mismatch: /stackable/nifi-2.2.0 (Owner: rwx, Group: r-x)
0.843 Permission and Ownership checks failed for /stackable!

@maltesander maltesander marked this pull request as ready for review March 26, 2025 17:28
@maltesander maltesander moved this to Development: Waiting for Review in Stackable Engineering Mar 26, 2025
@siegfriedweber siegfriedweber self-requested a review April 3, 2025 13:57
@siegfriedweber siegfriedweber moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 3, 2025
siegfriedweber
siegfriedweber previously approved these changes Apr 9, 2025
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander maltesander added this pull request to the merge queue Apr 9, 2025
Merged via the queue into main with commit a894f24 Apr 9, 2025
3 checks passed
@maltesander maltesander deleted the fix/druid-reduce-image-size branch April 9, 2025 06:48
@maltesander maltesander moved this from Development: In Review to Development: Done in Stackable Engineering Apr 9, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants