-
-
Notifications
You must be signed in to change notification settings - Fork 6
fix: Add --locked flag to cargo install commands
#1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLarsenNZ
approved these changes
Apr 2, 2025
Member
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good spotting!
xeniape
added a commit
that referenced
this pull request
Apr 2, 2025
xeniape
added a commit
that referenced
this pull request
Apr 2, 2025
xeniape
added a commit
that referenced
this pull request
Apr 2, 2025
xeniape
added a commit
that referenced
this pull request
Apr 2, 2025
xeniape
added a commit
that referenced
this pull request
Apr 4, 2025
xeniape
added a commit
that referenced
this pull request
Apr 4, 2025
xeniape
added a commit
that referenced
this pull request
Apr 4, 2025
xeniape
added a commit
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
--lockedflag to the cargo install commands to use the same dependencies and versions as defined in theCargo.lockfile to prevent older builds to resolve to newer versions and consequently breaking the build. This needs to be cherry-picked into older release branches.Example error when building nifi on
release-24.11branch:Definition of Done Checklist
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
baketo retrieve the image tag for<image-tagged-with-the-major-version>.