Skip to content

Use check permissions script and consolidation #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 9, 2025
Merged

Use check permissions script and consolidation #1053

merged 7 commits into from
Apr 9, 2025

Conversation

@maltesander
Copy link
Member

@maltesander maltesander commented Apr 7, 2025

Description

part of #961

No image size reduction, just consolidation.

  • Does remove the recursive chmod/chown in the final image and attempts non recursive chmod/chown or doing as much as possible in the builder step.
  • Uses check-permissions-ownership script to validate any wrong permissions / ownership in the /stackable folder

@maltesander maltesander self-assigned this Apr 7, 2025
@maltesander maltesander mentioned this pull request Apr 7, 2025
Closed
@maltesander maltesander moved this to Development: Waiting for Review in Stackable Engineering Apr 7, 2025
@siegfriedweber siegfriedweber self-requested a review April 7, 2025 10:10
@siegfriedweber siegfriedweber moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 7, 2025
siegfriedweber
siegfriedweber previously approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander maltesander added this pull request to the merge queue Apr 9, 2025
Merged via the queue into main with commit fe6b07a Apr 9, 2025
3 checks passed
@maltesander maltesander deleted the fix/superset-fix-size-consolidation branch April 9, 2025 07:05
@maltesander maltesander moved this from Development: In Review to Development: Done in Stackable Engineering Apr 9, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees

@maltesander maltesander

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maltesander @siegfriedweber