Skip to content

feat: make image namespace a workflow input (default sdp) #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025
Merged

feat: make image namespace a workflow input (default sdp) #1072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43b826a
feat: make image namespace a workflow input (default sdp)
razvan May 2, 2025
c3795eb
feat: add registry namespace input to build workflows and remove default
razvan May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build_airflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,4 @@ jobs:
with:
product-name: airflow
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_druid.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ jobs:
with:
product-name: druid
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_hadoop.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ jobs:
with:
product-name: hadoop
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_hbase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,4 @@ jobs:
with:
product-name: hbase
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_hello-world.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,4 @@ jobs:
with:
product-name: hello-world
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_hive.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,4 @@ jobs:
with:
product-name: hive
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_java-base.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,4 @@ jobs:
with:
product-name: java-base
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_java-devel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,4 @@ jobs:
with:
product-name: java-devel
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_kafka-testing-tools.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ jobs:
with:
product-name: kafka-testing-tools
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_kafka.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,4 @@ jobs:
with:
product-name: kafka
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_kcat.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ jobs:
with:
product-name: kcat
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_krb5.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,4 @@ jobs:
with:
product-name: krb5
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_nifi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ jobs:
with:
product-name: nifi
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_omid.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ jobs:
with:
product-name: omid
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_opa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,4 @@ jobs:
with:
product-name: opa
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_spark-connect-client.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,4 @@ jobs:
with:
product-name: spark-connect-client
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: stackable
1 change: 1 addition & 0 deletions .github/workflows/build_spark-k8s.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,4 @@ jobs:
with:
product-name: spark-k8s
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_stackable-base.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,4 @@ jobs:
with:
product-name: stackable-base
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_superset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,4 @@ jobs:
with:
product-name: superset
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_testing-tools.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,4 @@ jobs:
with:
product-name: testing-tools
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_tools.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,4 @@ jobs:
with:
product-name: tools
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_trino-cli.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,4 @@ jobs:
with:
product-name: trino-cli
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_trino.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ jobs:
with:
product-name: trino
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_vector.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,4 @@ jobs:
with:
product-name: vector
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
1 change: 1 addition & 0 deletions .github/workflows/build_zookeeper.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ jobs:
with:
product-name: zookeeper
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
registry-namespace: sdp
7 changes: 5 additions & 2 deletions .github/workflows/reusable_build_image.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ on:
sdp-version:
required: true
type: string
registry-namespace:
required: true
type: string
secrets:
harbor-robot-secret:
description: The secret for the Harbor robot user used to push images and manifest
Expand Down Expand Up @@ -66,7 +69,7 @@ jobs:
image-registry-uri: oci.stackable.tech
image-registry-username: robot$sdp+github-action-build
image-registry-password: ${{ secrets.harbor-robot-secret }}
image-repository: sdp/${{ inputs.product-name }}
image-repository: ${{ inputs.registry-namespace }}/${{ inputs.product-name }}
image-manifest-tag: ${{ steps.build.outputs.image-manifest-tag }}
source-image-uri: localhost/${{ inputs.product-name }}:${{ steps.build.outputs.image-manifest-tag }}

Expand All @@ -92,7 +95,7 @@ jobs:
image-registry-uri: oci.stackable.tech
image-registry-username: robot$sdp+github-action-build
image-registry-password: ${{ secrets.harbor-robot-secret }}
image-repository: sdp/${{ inputs.product-name }}
image-repository: ${{ inputs.registry-namespace }}/${{ inputs.product-name }}
image-index-manifest-tag: ${{ matrix.versions }}-stackable${{ inputs.sdp-version }}

notify:
Expand Down