Skip to content

Conversation

@dervoeti
Copy link
Member

@dervoeti dervoeti commented May 19, 2025

Description

We currently include NARs in the NiFi image but not their SBOMs (except for the Iceberg NAR we build manually), even though they are generated. This change copies the generated SBOMs into the final image so we can see the full dependency tree for all components in NAR files.

I also changed the suffix of the Iceberg SBOM from .sbom.json to .cdx.json to match the suffix of the other SBOMs.

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@dervoeti dervoeti requested a review from a team May 19, 2025 08:54
@dervoeti dervoeti moved this to Development: Waiting for Review in Stackable Engineering May 19, 2025
@dervoeti dervoeti self-assigned this May 19, 2025
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 19, 2025
@dervoeti dervoeti added this pull request to the merge queue May 19, 2025
Merged via the queue into main with commit 91545e5 May 19, 2025
3 checks passed
@dervoeti dervoeti deleted the feat/nifi-sboms-for-nars branch May 19, 2025 09:45
@dervoeti dervoeti moved this from Development: In Review to Development: Done in Stackable Engineering May 19, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants