Skip to content

Conversation

@lfrancke
Copy link
Member

@lfrancke lfrancke commented Jun 2, 2025

Description

We copy the entrypoint script fromt he "official" Dockerfiles and we haven't updated that in two years.
This does just that and in addition it does disable the UID & GID check which we believe to be wrong. The GID doesn't need to be zero on Vanilla K8s and OpenShift handles it itself.

See stackabletech/issues#651 for details

Definition of Done Checklist

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully

@lfrancke lfrancke force-pushed the feat/update-entrypoint branch from 1a216f8 to febfdf4 Compare June 2, 2025 09:56
@lfrancke lfrancke marked this pull request as ready for review June 2, 2025 09:56
@lfrancke lfrancke enabled auto-merge June 2, 2025 09:56
@lfrancke lfrancke self-assigned this Jun 2, 2025
@lfrancke lfrancke moved this to Development: Waiting for Review in Stackable Engineering Jun 2, 2025
@adwk67 adwk67 self-requested a review June 3, 2025 15:25
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 3, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I got a couple of OOM failures with the tests but that is not related to this PR.

@lfrancke lfrancke added this pull request to the merge queue Jun 4, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jun 4, 2025
…check (#1138)

chore: Update the Airflow entrypoint script and remove the UID & GID
check
Merged via the queue into main with commit ccf7c6e Jun 4, 2025
3 checks passed
@lfrancke lfrancke deleted the feat/update-entrypoint branch June 4, 2025 09:53
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Jun 4, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants