- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 6
chore: Change default user id and gid #1164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6e517d2    to
    29694c6      
    Compare
  
    | I have tested this by installing the waterlevel demo on 25.3, updated everything to current 0.0.0-dev and then updated to use custom built images with this PR included. All pods and tools came up without a problem. The FSGroup setting makes it possible that all mounts are still readable/writable. | 
29694c6    to
    dd85797      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tests!
* Change UID & GID to 1000/1000, reverting the previous change from PR #1164 * chore: Set default GID to 0 * chore: Update changelog --------- Co-authored-by: Nick Larsen <[email protected]>
* Change UID & GID to 1000/1000, reverting the previous change from PR #1164 * chore: Set default GID to 0 * chore: Update changelog --------- Co-authored-by: Nick Larsen <[email protected]>
Description
Part of stackabletech/issues#645
Part of stackabletech/issues#651
Note
This was already applied once before and later reverted.
It was merged prematurely back then but now the immediate parent issue has been done and it should be good to go again
Change default user id and gid to the same ones we use in the operators themselves.
These are only the defaults that are used when a Pod does not specify their own
securityContext.runAsUserorrunAsGroup.All of our operators have been changed to not set the user and group id anymore which means they'll fall back to the values from the image.
Definition of Done Checklist
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
baketo retrieve the image tag for<image-tagged-with-the-major-version>.