-
-
Notifications
You must be signed in to change notification settings - Fork 7
chore(krb5-testing-tools): Rename image #1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Note, there are other images that should also be move to the
|
The image builds:
|
|
I was going to call it I don't mind though. |
Ah, right. For some reason I thought we set |
I'll raise the PRs (ad-init,
|
# krb5-testing-tools | ||
|
||
> [!CAUTION] | ||
> This image is only intended for Stackable-internal tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use it in demos too, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take another look, but I didn't see a usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah... so it's name is kind of bad.
We'll think of an alternative name - otherwise I'll drop the PR.
@sbernauer and I chatted about potential naming this morning, as it is used in:
For:
Considering that, we feel Name ideas
|
Staying with |
Caution
Blocking this on #1224 so I don't cause extra merge conflicts while it is in review.
The image is not part of the SDP platform, so I recommend we move it to the correct Harbor project, and rename the image so indicate its usage.
Tip
Update image references in ad-init and
hdfs-topology-provider, hdfs-utils, demos. Be sure to use Harbor and the correct project (stackable
instead ofsdp
).