Skip to content

Conversation

@dervoeti
Copy link
Member

Description

Part of #1068

This PR enables custom versions (with a suffix like -stackable0.0.0-dev) for Zookeeper.

In the SBOM, the custom version is replaced by the original one (using sed), so vulnerabilities filed directly against Zookeeper are still detected by scanners when scanning the SBOM.

I built Zookeeper 3.9.3, tested it with the smoke test and manually validated that it reported the correct version.

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@dervoeti dervoeti moved this to Development: Waiting for Review in Stackable Engineering Jun 13, 2025
@dervoeti dervoeti self-assigned this Jun 13, 2025
@maltesander maltesander self-requested a review June 16, 2025 15:28
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 16, 2025
maltesander
maltesander previously approved these changes Jun 16, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dervoeti dervoeti added this pull request to the merge queue Jun 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jun 16, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dervoeti dervoeti added this pull request to the merge queue Jun 20, 2025
@dervoeti dervoeti moved this from Development: In Review to Development: Done in Stackable Engineering Jun 20, 2025
Merged via the queue into main with commit 24d8390 Jun 20, 2025
3 checks passed
@dervoeti dervoeti deleted the feat/custom-product-versions-zookeeper branch June 20, 2025 08:12
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants