Use custom Maven version for all our products #1220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfrancke
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
maltesander
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
lfrancke
moved this from Development: In Review
to Development: Done
in Stackable Engineering
lfrancke
moved this from Development: Done
to Acceptance: In Progress
in Stackable Engineering
|
I noticed there is no upload script for adding the dependency to Nexus (like we do for others). |
|
Thank you! I indeed forgot about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/fixes #1181
Maven as of 3.9+ supports an environment variable
MAVEN_ARGSto standardise certain arguments to be used for every Maven invocation. This allows us to globally silence the transfer progress and enable batch mode and it allows us to remove the workarounds we had in place for Spark, Trino and NiFi.How this was tested
I manually built all images and they succeeded. I did not run any integration tests or anything but I believe that once they built successfully it should be good.
Definition of Done Checklist