Add ZOOCFGDIR env variable to ZooKeeper to make scripts work #1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltesander
reviewed
Oct 6, 2025
| ENV PATH="${PATH}":/stackable/zookeeper/bin | ||
| # This is used by zkEnv.sh and for the shell scripts in bin/ | ||
| # If unset it tries to find the conf directory automatically and that fails | ||
| ENV ZOOCFGDIR=/stackable/config |
There was a problem hiding this comment.
Hmm, we have a rwconfig as well for the real config https://github.com/stackabletech/zookeeper-operator/blob/e370101dfe986e862c0354f6a50471b857d0c078/rust/operator-binary/src/zk_controller.rs#L927.
Its created by the operator though...maybe this should be set in the operator?
lfrancke
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
lfrancke
moved this from Development: In Review
to Development: Waiting for Review
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This works around https://issues.apache.org/jira/browse/ZOOKEEPER-4985
If we don't set this variable most of the shell scripts will fail (definitely zkCleanup.sh).
It can be set manually before every call but we do know the location of the config directory so no harm in making it a bit easier.
I didn't think this needed a changelog entry, happy to add if you think otherwise.
Definition of Done Checklist