Skip to content

chore(hbase): Convert sed calls to config-utils where possible #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2025
Merged

chore(hbase): Convert sed calls to config-utils where possible #1301

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7cad2c4
convert sed calls to config-utils where possible
adwk67 Oct 8, 2025
67dd5e2
changelog
adwk67 Oct 8, 2025
6646a55
Merge branch 'main' into chore/hbase-use-config-utils
adwk67 Oct 9, 2025
05484a1
changelog order
adwk67 Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ All notable changes to this project will be documented in this file.
- trino-cli: Bump to 477 ([#1285]).
- tools: Bump dependency versions - kubectl to `1.34.1`, yq to `4.47.2`, and jq to `1.8.1` ([#1290]).
- testing-tools: Update keycloak dependency to `26.3.5` and `python:3.12-slim-bullseye` base image ([#1289]).
- hbase: replace `sed` calls with `config-utils template` where possible ([#1301]).

### Removed

Expand Down Expand Up @@ -89,6 +90,7 @@ All notable changes to this project will be documented in this file.
[#1292]: https://github.com/stackabletech/docker-images/pull/1292
[#1293]: https://github.com/stackabletech/docker-images/pull/1293
[#1296]: https://github.com/stackabletech/docker-images/pull/1296
[#1301]: https://github.com/stackabletech/docker-images/pull/1301

## [25.7.0] - 2025-07-23

Expand Down
17 changes: 9 additions & 8 deletions hbase/hbase/stackable/bin/hbase-entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ HBASE_UI_PORT_NAME="$4"

# Needed for regionmover service and for hbase-site.xml (see below)
HBASE_SERVICE_HOST=$(cat /stackable/listener/default-address/address)
export HBASE_SERVICE_HOST

REGION_MOVER_OPTS="--regionserverhost ${HBASE_SERVICE_HOST}:${HBASE_ROLE_SERVICE_PORT} --operation unload ${REGION_MOVER_OPTS}"

Expand Down Expand Up @@ -57,9 +58,9 @@ wait_for_termination() {
set -e
}

# ##################################################################################################
# #############################################################################
# main
# ##################################################################################################
# #############################################################################
mkdir -p /stackable/conf
cp /stackable/tmp/hdfs/hdfs-site.xml /stackable/conf
cp /stackable/tmp/hdfs/core-site.xml /stackable/conf
Expand All @@ -70,20 +71,20 @@ cp /stackable/tmp/log_config/log4j* /stackable/conf
if [ -f /stackable/kerberos/krb5.conf ]; then
KERBEROS_REALM=$(grep -oP 'default_realm = \K.*' /stackable/kerberos/krb5.conf)
export KERBEROS_REALM
# the hdfs discovery files are not written by the hbase operator and use
# the dot notation, so they cannot be used with config-utils
sed -i -e s/\$\{env\.KERBEROS_REALM\}/"${KERBEROS_REALM}"/g /stackable/conf/core-site.xml
sed -i -e s/\$\{env\.KERBEROS_REALM\}/"${KERBEROS_REALM}"/g /stackable/conf/hbase-site.xml
sed -i -e s/\$\{env\.KERBEROS_REALM\}/"${KERBEROS_REALM}"/g /stackable/conf/hdfs-site.xml
fi

# Service endpoints
HBASE_SERVICE_PORT=$(cat /stackable/listener/default-address/ports/"${HBASE_PORT_NAME}")
HBASE_INFO_PORT=$(cat /stackable/listener/default-address/ports/"${HBASE_UI_PORT_NAME}")
HBASE_LISTENER_ENDPOINT="$HBASE_SERVICE_HOST:$HBASE_INFO_PORT"

sed -i -e s/\$\{HBASE_SERVICE_HOST\}/"${HBASE_SERVICE_HOST}"/g /stackable/conf/hbase-site.xml
sed -i -e s/\$\{HBASE_SERVICE_PORT\}/"${HBASE_SERVICE_PORT}"/g /stackable/conf/hbase-site.xml
sed -i -e s/\$\{HBASE_LISTENER_ENDPOINT\}/"${HBASE_LISTENER_ENDPOINT}"/g /stackable/conf/hbase-site.xml
sed -i -e s/\$\{HBASE_INFO_PORT\}/"${HBASE_INFO_PORT}"/g /stackable/conf/hbase-site.xml
export HBASE_SERVICE_PORT
export HBASE_INFO_PORT

config-utils template /stackable/conf/hbase-site.xml

rm -f "${STACKABLE_LOG_DIR}/_vector/shutdown"
prepare_signal_handlers
Expand Down
Loading