Skip to content

fix: pin luxon to fix 4.1.2 build #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
Merged

fix: pin luxon to fix 4.1.2 build #1316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ All notable changes to this project will be documented in this file.
- hbase: move hbck2.env to hbase-operator-tools image and add log4j2 properties for this tool ([#1300]).
- hbase: replace `sed` calls with `config-utils template` where possible ([#1301]).
- superset: Fix the 4.1.2 build when building from source ([#1309])
- superset: Pin `luxon` to version 3.6.1 to fix build ([#1315])
- superset: Pin `luxon` to version 3.6.1 to fix build ([#1315], [#1316])

### Fixed

Expand Down Expand Up @@ -108,6 +108,7 @@ All notable changes to this project will be documented in this file.
[#1309]: https://github.com/stackabletech/docker-images/pull/1309
[#1311]: https://github.com/stackabletech/docker-images/pull/1311
[#1315]: https://github.com/stackabletech/docker-images/pull/1315
[#1316]: https://github.com/stackabletech/docker-images/pull/1316

## [25.7.0] - 2025-07-23

Expand Down
8 changes: 4 additions & 4 deletions superset/stackable/patches/4.1.2/0001-fix-pin-luxon-to-fix-build.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
From 1b11f3ff47f46105289f7f9dcaa4fc10d6ea3571 Mon Sep 17 00:00:00 2001
From fcff47eb39942ca5699ca31046ac0130da54fee8 Mon Sep 17 00:00:00 2001
From: dervoeti <[email protected]>
Date: Wed, 22 Oct 2025 17:04:19 +0200
Subject: fix: pin luxon to fix build

For some reason npm tries to use a newer version of luxon than the version in the lock file. I suspect this might be related to how npm before version 11 handles workspace dependencies in lock files. The luxon version is set to 3.6.1 now to prevent npm from trying to select a newer version, so that the same packages as in the original Superset build are used.
For some reason npm tries to use a newer version of luxon than the version in the lock file. I suspect this might be related to how npm before version 11 handles workspace dependencies in lock files. The luxon version is set to 3.5.0 now to prevent npm from trying to select a newer version, so that the same packages as in the original Superset build are used.
---
superset-frontend/package.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset-frontend/package.json b/superset-frontend/package.json
index ebca197a25..3490ecaa93 100644
index ebca197a25..bb2641a67f 100644
--- a/superset-frontend/package.json
+++ b/superset-frontend/package.json
@@ -148,7 +148,7 @@
"json-bigint": "^1.0.0",
"json-stringify-pretty-compact": "^2.0.0",
"lodash": "^4.17.21",
- "luxon": "^3.5.0",
+ "luxon": "3.6.1",
+ "luxon": "3.5.0",
"mapbox-gl": "^2.10.0",
"markdown-to-jsx": "^7.4.7",
"match-sorter": "^6.3.4",
Loading